Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

short-name aliasing #7964

Merged
merged 1 commit into from
Nov 13, 2020
Merged

short-name aliasing #7964

merged 1 commit into from
Nov 13, 2020

Conversation

vrothberg
Copy link
Member

Based on containers/image#1061 to allow for testing and playing around.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
mheon
mheon reviewed Oct 8, 2020
View reviewed changes
libpod/image/pull.go Outdated Show resolved Hide resolved
@jwhonce jwhonce mentioned this pull request Oct 9, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2020
@vrothberg vrothberg force-pushed the shortnames branch 3 times, most recently from f28e6a5 to 32fff74 Compare October 20, 2020 10:40
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2020
@vrothberg vrothberg force-pushed the shortnames branch 2 times, most recently from e2a3205 to 6f00ddb Compare October 20, 2020 13:03
@vrothberg
Copy link
Member Author

/retest

@vrothberg
Copy link
Member Author

@baude @cevich ... it looks like the upper system tests were cancelled because the integration test of another $distro-$version flaked. I cannot restart them in the UI. Do you know how to restart them?

@vrothberg
Copy link
Member Author

Ah ! It seems they're restarting on their own, awesome!

@edsantiago
Copy link
Member

Sorry if this is a stupid question, but how are you planning to handle podman-remote? Right now it just prompts on the server side (which the remote user can never see). I've tried my best to search for 'remote' in this PR.

@vrothberg
Copy link
Member Author

Sorry if this is a stupid question, but how are you planning to handle podman-remote? Right now it just prompts on the server side (which the remote user can never see). I've tried my best to search for 'remote' in this PR.

We don't (yet?) have special plans for remote. Depending on the configuration, the service endpoint may either fall back to trying out all search registries or it will error out.

Wiring prompting into the remote client would be quite a challenge. We had to do all the magic to remote-control the terminal for prompting and change an unknown amount of interfaces in the code to pass down the remote stream through all code paths that may (or may not) reach short-name resolution.

@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

Note that you need to set CONTAINERS_SHORT_NAME_ALIASING=on until we move the main branch over to Podman 3.0 dev.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2020
@vrothberg vrothberg force-pushed the shortnames branch 2 times, most recently from 72f9b8d to 2720028 Compare October 25, 2020 10:39
@vrothberg vrothberg force-pushed the shortnames branch 3 times, most recently from db63a7d to 6d37f00 Compare November 6, 2020 13:25
@mtrmac mtrmac mentioned this pull request Nov 6, 2020
Merged
@vrothberg vrothberg force-pushed the shortnames branch 2 times, most recently from edfbfda to 2a8cfff Compare November 13, 2020 14:16
@vrothberg vrothberg changed the title WIP - short-name aliasing short-name aliasing Nov 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

Note that this PR vendors a non-release Buildah. My weekend is coming closer and we don't need to block until a Buildah release for this to be merged (or even for an RC).

@mheon
Copy link
Member

mheon commented Nov 13, 2020

LGTM

@vrothberg
short-name aliasing
8e4a42a 
Add support for short-name aliasing.

Signed-off-by: Valentin Rothberg <[email protected]>
@rhatdan rhatdan changed the title short-name aliasing [wip] short-name aliasing Nov 13, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@vrothberg
Copy link
Member Author

@rhatdan why did you re-wip?

@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2020

Because of the Buildah vendor.

@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2020

You could merge if you want, but we can not release until Buildah version bump.

@vrothberg
Copy link
Member Author

@rhatdan, we don't need to block this PR on the Buildah release. We can vendor Buildah again later. I'll be on PTO on Monday and don't want to block Podman.

@rhatdan rhatdan changed the title [wip] short-name aliasing short-name aliasing Nov 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit 738d62e into containers:master Nov 13, 2020
@vrothberg vrothberg deleted the shortnames branch November 13, 2020 19:28
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrothberg @openshift-ci-robot @edsantiago @mheon @rhatdan @openshift-merge-robot