system tests: cleanup, and add more tests #7949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- images test: add test for 'table' and '\t' formatting - image mount test: check output from 'umount', test repeat umount (NOP), and test invalid-umount - kill test: remove kludgy workaround for crun signal bug ref: containers#5004 -- code is no longer needed (fingers crossed), and the workaround involved pulling an expensive image. - selinux test: add new tests for shared context in: * pods , w/ and w/o infra container (ref: containers#7902) * containers with namespace sharing: --ipc, --pid, --net - selinux test: new test for --pid=host (disabled pending propagation of container-selinux-2.146, ref: containers#7939) Signed-off-by: Ed Santiago <[email protected]>
openshift-ci-robot
added
the
approved
rhatdan
reviewed
Oct 10, 2020
| @@ -75,4 +91,84 @@ function check_label() { | |||
| run_podman rm -f myc | |||
| } | |||
|
|
|||
| # Sharing context between two containers not in a pod | |||
| # These tests were piggybacked in with #7902, but are not actually related | |||
| @test "podman selinux: shared context in (some) namespaces" { | |||
There was a problem hiding this comment.
Nice, there are a few more we might want to add around making sure a systemd based container gets the
container_init_t and a kvm (kata) container gets container_kvm_t.
|
LGTM |
saschagrunert
approved these changes
Oct 12, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
images test: add test for 'table' and '\t' formatting
image mount test: check output from 'umount', test
repeat umount (NOP), and test invalid-umount
kill test: remove kludgy workaround for crun signal bug
ref: Podman-remote mangles SIGINT #5004 -- code is no longer needed (fingers crossed),
and the workaround involved pulling an expensive image.
selinux test: add new tests for shared context in:
selinux test: new test for --pid=host (disabled pending
propagation of container-selinux-2.146, ref: SELinux, rootless, --pid=host: only works with vfs #7939)
Signed-off-by: Ed Santiago [email protected]