Fix handling of CheckRootlessUIDRange #7919
Conversation
openshift-ci-robot
added
the
approved
|
@giuseppe PTAL |
If I have multiple ranges of UIDs specified in the /etc/subuid, this check blows up and incorrectly blocks the use of --user flag. Signed-off-by: Daniel J Walsh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| total += u.Size | ||
| } | ||
| if uid > total { | ||
| return errors.Errorf("requested user's UID %d is too large for the rootless user namespace", uid) |
There was a problem hiding this comment.
Does it make sense to keep this if statement inside of the for still to have it break ASAP?
There was a problem hiding this comment.
No because we need to add all of the ranges together to see if UID is less then. We could check on each loop, I guess to see if it is less then, but that seems to be an optimization with little value. There are not going to be large numbers of ranges in the /etc/subuid file.
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
If I have multiple ranges of UIDs specified in the /etc/subuid, this check
blows up and incorrectly blocks the use of --user flag.
Signed-off-by: Daniel J Walsh [email protected]