Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podman-remote ps --ns broken #7909

Merged

Conversation

zhangguanzhang
Copy link
Collaborator

@zhangguanzhang zhangguanzhang commented Oct 3, 2020

Fixes: #7903
before

$ podman-remote  --url tcp://localhost:8081 ps  --ns --format \
    '{{with .Namespaces}}{{.Cgroup}}:{{.IPC}}:{{.MNT}}:{{.NET}}:{{.PIDNS}}:{{.User}}:{{.UTS}}{{end}}'
::::::

after

$ ./bin/podman-remote  --url tcp://localhost:8081 ps  --ns --format \
    '{{with .Namespaces}}{{.Cgroup}}:{{.IPC}}:{{.MNT}}:{{.NET}}:{{.PIDNS}}:{{.User}}:{{.UTS}}{{end}}'
4026531835:4026532341:4026532339:4026532278:4026532342:4026531837:4026532340

Signed-off-by: zhangguanzhang [email protected]

@zhangguanzhang zhangguanzhang requested a review from rhatdan October 3, 2020 13:51
@rhatdan
Copy link
Member

rhatdan commented Oct 4, 2020

Could you check if this PR fixes the FIXMEs in test/e2e/pod_infra_container_test.go

@rhatdan
Copy link
Member

rhatdan commented Oct 4, 2020

Thanks.
I tried it locally and it seems to fix most of those tests, Could you remove the Skips,
LGTM

Signed-off-by: zhangguanzhang <[email protected]>
@zhangguanzhang
Copy link
Collaborator Author

Thanks.
I tried it locally and it seems to fix most of those tests, Could you remove the Skips,
LGTM

this step special_testing_rootless RCLI:true in the ci failed, it need restart

@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@mheon
Copy link
Member

mheon commented Oct 5, 2020

LGTM

@zhangguanzhang
Copy link
Collaborator Author

this step special_testing_rootless RCLI:true in the ci failed, it need restart

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/lgtm
/hold
Restarted timed out job.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit a9d572f into containers:master Oct 5, 2020
@zhangguanzhang zhangguanzhang deleted the remote-ps-ns-broken branch November 18, 2020 09:34
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman-remote ps -a --ns is broken
6 participants