[podman-remote] Fix closed connection on pull causes service panic #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
|
LGTM, I'll defer to @mheon but I think this is the best way out given I couldn't find where in the low level code anyone was checking the context expiring. |
zhangguanzhang
force-pushed
the
service-panic-client-kill
branch
from
e0de719 to
087ea5e
Compare
zhangguanzhang
changed the title
Signed-off-by: zhangguanzhang <[email protected]>
zhangguanzhang
force-pushed
the
service-panic-client-kill
branch
from
087ea5e to
e386ca5
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I don't see how this is fixing #7896. The service is still going down. |
|
Apologies. I used the wrong binary for testing. The |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7896
Signed-off-by: zhangguanzhang [email protected]