Fix Podman logs reading journald #7893
Conversation
|
Throwing these tests at CI - let's see if they work, since having them turned on would have prevented this regression. |
|
Nice work if this fixes the problem. @ashley-cui |
There was a problem hiding this comment.
LGTM
Nice work, @ashley-cui! One line changes can sometimes be the most complex.
|
Tested locally 👍 So cool to see it work! |
|
LGTM
…On Fri, Oct 2, 2020, 09:19 Valentin Rothberg ***@***.***> wrote:
Tested locally 👍 So cool to see it work!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7893 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCAI6V2HJKMXJW3KCSLSIXHPLANCNFSM4SBVKPIA>
.
|
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
A podman could not read logs written to journald properly, due to a tail config bug. Added a system test to check this - since e2e tests don't like journald Signed-off-by: Ashley Cui <[email protected]>
|
Looks like integration tests don't like journald, but the system test might. let's see how CI reacts. |
|
New test (and green!) @containers/podman-maintainers PTAL |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
A podman could not read logs written to journald properly, due to a tail config bug. Also, turned on some journald logging tests that let this regression to occur.
Fixes: #7476, Bugzilla 1873204
Signed-off-by: Ashley Cui [email protected]