-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capabilities: always set ambient and inheritable #7820
capabilities: always set ambient and inheritable #7820
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d151c0c
to
4954178
Compare
the test failure seems correct to me, why would we allow chown to work with
|
9eca9b2
to
8b75f22
Compare
LGTM |
cbf84a1
to
cbb0f21
Compare
/lgtm |
cbb0f21
to
a33e3c6
Compare
65bd084
to
b575e25
Compare
change capabilities handling to reflect what docker does. Bounding: set to caplist Inheritable: set to caplist Effective: if uid != 0 then clear; else set to caplist Permitted: if uid != 0 then clear; else set to caplist Ambient: clear Signed-off-by: Giuseppe Scrivano <[email protected]>
b575e25
to
703381b
Compare
/lgtm |
/hold let's make sure tests are still passing :-) |
/hold cancel |
@giuseppe this likely needs to be backported to v2.1 |
backport: #7898 |
change capabilities handling to reflect what docker does.
Bounding: set to caplist
Inheritable: set to caplist
Effective: if uid != 0 then clear; else set to caplist
Permitted: if uid != 0 then clear; else set to caplist
Ambient: clear
Signed-off-by: Giuseppe Scrivano [email protected]