Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating on supported restart policy #7788

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Updating on supported restart policy #7788

merged 1 commit into from
Sep 29, 2020

Conversation

IceCodeNew
Copy link
Contributor

No description provided.

@IceCodeNew
Copy link
Contributor Author

/assign @giuseppe

@IceCodeNew IceCodeNew mentioned this pull request Sep 25, 2020
Merged
@rhatdan
Copy link
Member

rhatdan commented Sep 26, 2020

Thanks @IceCodeNew
You need to sign your PRs and squash them

git rebase -i origin
to squash
git commit -a --amend -s
git push --force

@TomSweeneyRedHat
Copy link
Member

and most importantly, TYVM @IceCodeNew for the PR!

Luap99
Luap99 reviewed Sep 26, 2020
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IceCodeNew It looks like you mixed up podman generate systemd --restart-policy and podman create/run --restart.

docs/source/markdown/podman-generate-systemd.1.md Outdated Show resolved Hide resolved
cmd/podman/common/create.go Outdated Show resolved Hide resolved
@Luap99
Copy link
Member

Luap99 commented Sep 29, 2020

LGTM
@rhatdan @TomSweeneyRedHat PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IceCodeNew, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2ee415b into containers:master Sep 29, 2020
@IceCodeNew IceCodeNew deleted the patch-1 branch September 29, 2020 23:37
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

@Luap99 Luap99 Awaiting requested review from Luap99

Assignees

@giuseppe giuseppe

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@IceCodeNew @rhatdan @TomSweeneyRedHat @Luap99 @openshift-ci-robot @giuseppe @openshift-merge-robot