Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SkipIfRootless if possible, document other calls #7786

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 25, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@rhatdan rhatdan force-pushed the rootless branch 3 times, most recently from 898bacd to 0031ad2 Compare September 26, 2020 13:24
@rhatdan
Copy link
Member Author

rhatdan commented Sep 28, 2020

@containers/podman-maintainers PTAL
Adding a bunch more tests to rootless, along with documenting why we are skipping tests.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 28, 2020

@edsantiago PTAL, I have a follow up PR to switch to using reason for all PRs, but I want to get this in first.

@giuseppe
Copy link
Member

LGTM

@edsantiago
Copy link
Member

LGTM. I'll need to enable one of the system tests (080-pause.bats) but first need to add a cgroups v1/v2 switch.

Thanks for doing this, I'm really heartened by the increasing test coverage.

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Sep 28, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit b0e70a6 into containers:master Sep 28, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants