Remove final v2remotefail failures

[rhatdan]

Most have been fixed, others I replaced with SkipIfRemote

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

LGTM

[rhatdan]

@edsantiago More tests for you...
@jwhonce @baude @QiWang19 @ashley-cui @TomSweeneyRedHat @vrothberg

The end of the v2remotefail, may it Rest In Peace.

[edsantiago]

This is probably beyond the scope of this PR, but I would love to see SkipIfRemote() extended to require a message, and use that message judiciously such as "mount" is meaningless over remote and FIXME: issue #12345. Otherwise LGTM (pending CI). Thank you for tackling this.

[edsantiago]

podman/test/e2e/stop_test.go

Lines 198 to 199 in 961a3d0

	It("podman stop all containers with one stopped", func() {
	Skip(v2remotefail)

[TomSweeneyRedHat]

LGTM

[edsantiago]

oooh, race condition! Reproducible! (one out of three attempts):

$ ./bin/podman-remote create --name test1 -it --rm alpine foo
91057d106cbbaecb67ad946dfa5c5b7357f732827679377c840bd192a0f393e7
$ ./bin/podman-remote start test1;./bin/podman-remote ps -aq
Error: executable file not found in $PATH: No such file or directory: OCI runtime command not found error
Error: container 91057d106cbbaecb67ad946dfa5c5b7357f732827679377c840bd192a0f393e7 does not exist in database: no such container

[rhatdan]

@edsantiago I just fixed a race condition on start, did you test with this latest PR?

[edsantiago]

@rhatdan I'm testing against your PR. All I'm doing is reproducing the failure I see in the CI logs.

[edsantiago]

These are some really unpleasant failures. (lots of hangs).

[edsantiago]

Bindings flake is #6518, restarted.

[rhatdan]

@edsantiago This is a lot closer to the way the podman start works, although there is a new FIXME, I had to add to get this in.

BTW I could see the current podman-remote start causing lots of weird flakes.

[edsantiago]

Errors are #7746 -- I thought you had re-added a SkipIfRemote() in that test?

[edsantiago]

If you rebase and decide to skip this again, please include `SkipIfRemote("FIXME: #7746") to make it easier for the 7746-fixer-person to find this. TIA.

[edsantiago]

docs looks like a Cirrus flake (connection something something). The other failure concerns me: podman-remote search alpine hung for 90 seconds. This is consistent with earlier "Expected process to exit. It did not." failures in previous iterations.

[edsantiago]

OMG tests are green after countless flakes!
/lgtm
/hold

[rhatdan]

/hold cancel