podman-remote untag image is broken

[rhatdan]

There seems to be some questionable code in NamesHistory which is not
returning the true value of the history. Basically this ends up truncating
the last item on the list which causes the test to fail.

Not sure if this code is still necessary or what it breaks.

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@mheon PTAL,

[mheon]

I think we need @vrothberg or @baude or someone else more familiar with the image code to comment here... I don't really know why this was added. Tests are red without it, though.

[vrothberg]

@saschagrunert added that code. It sounds reasonable to not display a name twice.

I am currently trying to reproduce the untag issue as I fail to see a relation at the moment.

[vrothberg]

It looks like a symptomatic fix. Local and remote untag should execute the same code. If there's a hiccup in remote, I suspect there's something else going on.

[vrothberg]

Looking closer at the untag endpoint, there are a couple of issues:

• It always requires a repo which the local client does not. podman untag $ID will remove all tags. That's currently not working and maybe something we need to add to the tests.
• There are parsing errors:

podman (master) $ ./bin/podman-remote images
REPOSITORY                TAG     IMAGE ID      CREATED       SIZE
docker.io/library/alpine  latest  a24bb4013296  3 months ago  5.85 MB
docker.io/library/alpine  2       a24bb4013296  3 months ago  5.85 MB
podman (master) $ ./bin/podman-remote untag docker.io/library/alpine:latest
Error: Failed to find image docker.io/library/alpine:latest: unable to find 'docker.io/library/alpine:latest' in local storage: no such image
podman (master) $ ./bin/podman-remote untag docker.io/library/alpine:latest
Error: Failed to find image docker.io/library/alpine:latest: unable to find 'docker.io/library/alpine:latest' in local storage: no such image

... and probably more

[vrothberg]

Untagging all is still broken as the endpoint forces a repo to be specified. I'll wrap up something for that and link it here.

[vrothberg]

It bit me in the tests in #7823

[vrothberg]

#7840

[rhatdan]

Replaced with #7840