Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more APIv2 tests for images. #7690

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Add more APIv2 tests for images. #7690

merged 1 commit into from
Oct 10, 2020

Conversation

Edward5hen
Copy link
Contributor

Covering:
push
tag
untag
rmi
image tree

Signed-off-by: Edward Shen [email protected]

@mheon
Copy link
Member

mheon commented Sep 18, 2020

I think gitvalidation is complaining that your commit subject includes trailing whitespace

@TomSweeneyRedHat
Copy link
Member

LGTM

edsantiago
edsantiago reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one request for cleanup. Thank you for your work on this!

test/apiv2/12-imagesMore.at
.RepoTags[1]=localhost:5000/myrepo:mytag

# Run registry container
podman run -d --name registry -p 5000:5000 docker.io/library/registry:2.6 /entrypoint.sh /etc/docker/registry/config.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop/rm this when finished

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After use it will be removed in line 38 - t DELETE libpod/containers/registry?force=true 204

@Edward5hen Edward5hen force-pushed the apiv2_images_more branch 2 times, most recently from f951c24 to 84be4cc Compare September 21, 2020 10:10
@edsantiago
Copy link
Member

@Edward5hen just checking in to make sure you're aware of the CI failures here

@Edward5hen
Copy link
Contributor Author

@edsantiago sorry, I'm replying late. I was taking PTO.

I'm confused about why we have this make error. It works quite well on my local machine.

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2020

@Edward5hen Could you rebase and see if the build works.

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

Thanks @Edward5hen
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Edward5hen, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7876dd5 into containers:master Oct 10, 2020
@edsantiago edsantiago mentioned this pull request Oct 19, 2020
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Edward5hen @mheon @TomSweeneyRedHat @edsantiago @rhatdan @openshift-ci-robot @openshift-merge-robot