fix the .Path and .Args when use the infra-command

[zhangguanzhang]

Fixes: #7673
Signed-off-by: zhangguanzhang [email protected]

[rhatdan]

LGTM

[rhatdan]

@zhangguanzhang Remote tests do not seem to be happy

[zhangguanzhang]

I will fix this when I have time

[edsantiago]

All tests are unhappy; but FWIW it now passes my (new, unsubmitted) --infra-image + --infra-command test. You're on the right track, thank you!

[edsantiago]

I have a system test (BATS) that tests this fairly thoroughly, so don't feel any need to write one. I will submit my PR as soon as yours merges (because, obviously, it will not pass on master right now).

[zhangguanzhang]

I have a system test (BATS) that tests this fairly thoroughly, so don't feel any need to write one. I will submit my PR as soon as yours merges (because, obviously, it will not pass on master right now).

Does this mean I should remove the e2e I wrote？

[edsantiago]

No, those are a good idea - multiple levels of testing are good. What I meant was, if you were thinking of writing a system test, you don't need to 😁

[zhangguanzhang]

My local test is normal, I don’t know why Args is empty in ci

[edsantiago]

You are using Expect(check1 when you should be using check2 😉

[zhangguanzhang]

You are using Expect(check1 when you should be using check2 😉

oops, wrong copy😅

[edsantiago]

I tested against my new BATS pod infra tests; all passes. Nice work.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Thanks @zhangguanzhang
/lgtm