Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix play_kube_test deployment template #7672

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix play_kube_test deployment template #7672

merged 1 commit into from
Sep 17, 2020

Conversation

xordspar0
Copy link
Contributor

Annotations were at the wrong indentation, making them a part of the
labels map.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2020
@xordspar0
Fix play_kube_test deployment template
7837afe 
Annotations were at the wrong indentation, making them a part of the
labels map.

Signed-off-by: Jordan Christiansen <[email protected]>
@xordspar0 xordspar0 marked this pull request as ready for review September 17, 2020 17:04
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2020
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2020

@haircommander @saschagrunert @vrothberg @mheon PTAL

@haircommander
Copy link
Collaborator

LGTM, thanks @xordspar0

@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons. Would like one more head nod from the folks @rhatdan listed though.

@QiWang19
Copy link
Contributor

LGTM

@mheon
Copy link
Member

mheon commented Sep 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@mheon
Copy link
Member

mheon commented Sep 17, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, xordspar0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0ee332a into containers:master Sep 17, 2020
@xordspar0 xordspar0 deleted the fix-template branch September 17, 2020 18:18
@xordspar0
Copy link
Contributor Author

🎉 Thanks everyone

@TomSweeneyRedHat
Copy link
Member

@xordspar0 Au contraire, merci beaucoup!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xordspar0 @rhatdan @haircommander @TomSweeneyRedHat @QiWang19 @mheon @openshift-ci-robot @openshift-merge-robot