Evict containers before removing via V2 API #7662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhonce
added
the
kind/test-flake
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cc @edsantiago |
|
@jwhonce I'm not sure the tests are buying into the change. |
jwhonce
force-pushed
the
issues/7535
branch
2 times, most recently
from
ef48270 to
361342a
Compare
|
Restarted the ubuntu failure, it looks like #7583. The bindings failure, though, looks real. |
edsantiago
reviewed
Sep 17, 2020
jwhonce
force-pushed
the
issues/7535
branch
from
361342a to
6c739b4
Compare
mheon
reviewed
Sep 18, 2020
Fixes containers#7535 Signed-off-by: Jhon Honce <[email protected]>
jwhonce
force-pushed
the
issues/7535
branch
from
6c739b4 to
ed930d9
Compare
|
LGTM |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code ported from abi container remove
Fixes #7535
Signed-off-by: Jhon Honce [email protected]