Fix remote logs #7660
Merged
Fix remote logs #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker compatibility - logs endpoint does not write stream headers if container has a tty Signed-off-by: Ashley Cui <[email protected]>
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
@vrothberg tagging so you have the link to this PR, thanks for helping me on this |
ashley-cui
removed
the
do-not-merge/work-in-progress
|
Update: this should fix remote logs the best we can: adding a tty to a container makes the logs add return carriage symbols, which is a tty quirk, so this should be an accpetable fix. See: moby/moby#37366 (comment) |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker compatibility - logs endpoint does not write stream headers if container has a tty
There are still some issues with logging behavior that affects this, we need to sort that out in the backend before we can know for certain if this is the right fix
Fixes: #7196
Signed-off-by: Ashley Cui [email protected]