Supports import&run--signature-policy #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiWang19
force-pushed
the
policy-option
branch
2 times, most recently
from
ffe1ae5 to
1cf900c
Compare
|
/approve |
openshift-ci-robot
added
the
approved
jwhonce
reviewed
Sep 14, 2020
libpod/runtime_img.go
Outdated
| @@ -174,7 +174,7 @@ func (r *Runtime) Build(ctx context.Context, options imagebuildah.BuildOptions, | |||
| } | |||
|
|
|||
| // Import is called as an intermediary to the image library Import | |||
| func (r *Runtime) Import(ctx context.Context, source string, reference string, changes []string, history string, quiet bool) (string, error) { | |||
| func (r *Runtime) Import(ctx context.Context, source, reference string, signaturePolicyPath string, changes []string, history string, quiet bool) (string, error) { | |||
There was a problem hiding this comment.
Suggested change
| func (r *Runtime) Import(ctx context.Context, source, reference string, signaturePolicyPath string, changes []string, history string, quiet bool) (string, error) { | |
| func (r *Runtime) Import(ctx context.Context, source, reference, signaturePolicyPath string, changes []string, history string, quiet bool) (string, error) { |
I would like to see either the type after each parameter or collapse all like parameters.
|
If you get a chance, please correct the typo in the title "Suppots" -> "Supports" |
QiWang19
changed the title
|
Touch up @jwhonce 's suggestion and the title, then LGTM. |
QiWang19
force-pushed
the
policy-option
branch
2 times, most recently
from
f063fc7 to
17b8e24
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
QiWang19
force-pushed
the
policy-option
branch
from
17b8e24 to
bd94ba6
Compare
|
@QiWang19 all kinds of tests upset. |
QiWang19
force-pushed
the
policy-option
branch
2 times, most recently
from
1ba6ef8 to
c123912
Compare
Enables podman create, pull, run, import to use --signature-policy option. Set it as hidden flag to be consistent with other commands. Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
policy-option
branch
from
c123912 to
2fcd1d7
Compare
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables podman create, pull, run, import to use --signature-policy option. Set it as hidden flag to be consistent with other commands.
Close #6053
Signed-off-by: Qi Wang [email protected]