Determine if resolv.conf points to systemd-resolved #7616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Vega <[email protected]>
EduardoVega
force-pushed
the
5845-support-for-systemd-resolved
branch
from
2a31288 to
6a12335
Compare
|
Thanks @EduardoVega |
openshift-ci-robot
added
the
approved
|
LGTM |
|
LGTM |
saschagrunert
approved these changes
Sep 14, 2020
Comment on lines
+1386
to
+1389
| // Determine if symlink points to any of the systemd-resolved files | ||
| if strings.HasPrefix(resolvPath, "/run/systemd/resolve/") { | ||
| resolvPath = "/run/systemd/resolve/resolv.conf" | ||
| } |
There was a problem hiding this comment.
Just a nit-pick: The logic for retrieving the resolvPath seems to be scattered around in the implementation and I would prefer having it in a own function.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EduardoVega, rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Merged
14 tasks
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5845
Signed-off-by: Eduardo Vega [email protected]