libpod: read mappings when joining a container userns #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
giuseppe
force-pushed
the
join-userns-reuse-mappings
branch
from
cf14140 to
135d184
Compare
|
LGTM |
giuseppe
force-pushed
the
join-userns-reuse-mappings
branch
from
135d184 to
046b4d7
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
giuseppe
force-pushed
the
join-userns-reuse-mappings
branch
from
046b4d7 to
4964ab7
Compare
giuseppe
force-pushed
the
join-userns-reuse-mappings
branch
from
4964ab7 to
686f6ec
Compare
|
/lgtm |
when joining an existing container user namespace, read the existing mappings so the storage can be created with the correct ownership. Closes: containers#7547 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when joining an existing container user namespace, read the existing
mappings so the storage can be created with the correct ownership.
Closes: #7547
Signed-off-by: Giuseppe Scrivano [email protected]