Fix podman ps -l #7568
Fix podman ps -l #7568
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| _, ec, _ := podmanTest.RunLsContainer("") | ||
| Expect(ec).To(Equal(0)) | ||
| _, ec, _ = podmanTest.RunLsContainer("") | ||
| Expect(ec).To(Equal(0)) |
There was a problem hiding this comment.
why the same code run twice
There was a problem hiding this comment.
Before ps -l would display all containers. To test for this case, we need at least two running containers.
There was a problem hiding this comment.
We need two running containers. The bug is that --latest should only show the 1 latest containers. The test was failing to find the bug, since there was only one running container.
| _, ec, _ := podmanTest.RunLsContainer("") | ||
| Expect(ec).To(Equal(0)) | ||
| _, ec, _ = podmanTest.RunLsContainer("") | ||
| Expect(ec).To(Equal(0)) |
There was a problem hiding this comment.
Before ps -l would display all containers. To test for this case, we need at least two running containers.
Currently the --latest flag is ignored by podman ps command. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1877182 Signed-off-by: Daniel J Walsh <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Currently the --latest flag is ignored by podman ps command.
Signed-off-by: Daniel J Walsh [email protected]