Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 27+ include Podman packages #756

Closed
wants to merge 1 commit into from

Conversation

davidstrauss
Copy link

No description provided.

@mheon
Copy link
Member

mheon commented May 11, 2018

Good catch, LGTM

@mheon
Copy link
Member

mheon commented May 11, 2018

@davidstrauss I think you need to sign your commit - git commit --amend -s and force-push should be enough.

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@mheon
Copy link
Member

mheon commented May 11, 2018

bot, add author to whitelist

@davidstrauss
Copy link
Author

I'll need to get my GPG house in order to sign the commit. I mostly use my GPG hardware tokens for SSH, so I don't have the proper subkey signing stuff configured yet. I've been meaning to fix things, though, so I'll do that and re-push.

@mheon
Copy link
Member

mheon commented May 11, 2018

@davidstrauss Oh, sorry, not a fully GPG signature, just a Signed-off-by line, should have been more clear

@wking
Copy link
Contributor

wking commented May 16, 2018

Docs for the missing Signed-off-by are here.

@TomSweeneyRedHat
Copy link
Member

@davidstrauss Thanks for the update and the catch. We need to get this in sooner rather than later so I've just spun up #779 stealing your update. Hope you can contribute again in the future!

@rhatdan
Copy link
Member

rhatdan commented May 16, 2018

Closing for #779
Thanks @davidstrauss

@rhatdan rhatdan closed this May 16, 2018
@davidstrauss
Copy link
Author

Thanks for the update and the catch. We need to get this in sooner rather than later so I've just spun up #779 stealing your update. Hope you can contribute again in the future!

No worries. For what it's worth, removing the Signed-Off-By requirement would make drive-by contributions (like those from clicking "Edit" on GitHub) easier.

@davidstrauss davidstrauss deleted the patch-1 branch May 16, 2018 20:36
edsantiago added a commit to edsantiago/libpod that referenced this pull request Nov 17, 2021
Includes a test for the stdout-goes-away bug (crun containers#756).

Skip on Ubuntu due to a many-months-old kernel bug that
keeps getting fixed and then un-fixed.

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants