-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedora 27+ include Podman packages #756
Conversation
Good catch, LGTM |
@davidstrauss I think you need to sign your commit - |
Can one of the admins verify this patch?
|
bot, add author to whitelist |
I'll need to get my GPG house in order to sign the commit. I mostly use my GPG hardware tokens for SSH, so I don't have the proper subkey signing stuff configured yet. I've been meaning to fix things, though, so I'll do that and re-push. |
@davidstrauss Oh, sorry, not a fully GPG signature, just a Signed-off-by line, should have been more clear |
Docs for the missing Signed-off-by are here. |
@davidstrauss Thanks for the update and the catch. We need to get this in sooner rather than later so I've just spun up #779 stealing your update. Hope you can contribute again in the future! |
Closing for #779 |
No worries. For what it's worth, removing the |
Includes a test for the stdout-goes-away bug (crun containers#756). Skip on Ubuntu due to a many-months-old kernel bug that keeps getting fixed and then un-fixed. Signed-off-by: Ed Santiago <[email protected]>
No description provided.