[2.0] Vendor in containers/storage v1.20.4

[rhatdan]

This will allow the passing down of the ignore_chown_errors flag from
/etc/containers/storage.conf for rootless containers.

Signed-off-by: Daniel J Walsh [email protected]

[rhatdan]

@mheon @vrothberg @baude @giuseppe @TomSweeneyRedHat @QiWang19 @ashley-cui @jwhonce PTAL

[rhatdan]

Fixes: #7513

[vrothberg]

LGTM

I think this calls for tests to prevent future regressions (Cc @edsantiago). @rhatdan, do you have an idea how we could easily test it? I guess we had to set up a new uid/gid mapping ideally with a range of 1.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@vrothberg the problem with testing this is we would need to modify the host system that is running the test to make it work, which @edsantiago frowns upon.

[vrothberg]

@vrothberg the problem with testing this is we would need to modify the host system that is running the test to make it work, which @edsantiago frowns upon.

That's what I feared. Couldn't we run it in a container?

[rhatdan]

Yes doing this in a privileged container might make sense. Do we have any examples of this though?

[vrothberg]

Yes doing this in a privileged container might make sense. Do we have any examples of this though?

I think we could reuse the podman images from Quay.io and mount a handcrafted /etc/sub{g,u}id? Then we'd need an image with more than one uids/gids.

[mheon]

/lgtm

[mheon]

Let's keep this as just a vendor update. If we want to add tests, we should do it against master first.