-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote api logs #7522
Fix remote api logs #7522
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
properly returning logs through remote api Signed-off-by: Ashley Cui <[email protected]>
show add some test like this
and the bug is not belong to the remote
|
@zhangguanzhang The logs wouldn't show because curl detected it as a binary, not application/json, so it didn't output anything.
Feel free to test this PR and see if it fixes the issue |
must try this with the |
@zhangguanzhang still works for me
|
with
|
@zhangguanzhang I'm not sure what the cat -A has to do with the remote podman logs command, since podman logs works. |
In this case, I may need to open a new issue |
@zhangguanzhang It might be worthwhile, since this PR is dealing with remote log output, not cli as you have been looking at |
uh oh looks like i broke something while fixing something.. |
properly returning logs through remote api
Closes: #7196
Closes: #6628
Signed-off-by: Ashley Cui [email protected]