Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create ~/.config after removing storage.conf #7519

Merged

Conversation

cyruseuros
Copy link
Contributor

Fixes #7509. There is no need to create a ~/.config directory now that
~/.config/containers/storage.conf is not created automatically. Podman
has no use for it if it does not exist already.

@rhatdan
Copy link
Member

rhatdan commented Sep 1, 2020

LGTM
Thanks @jjzmajic
You need to sign your commits.

git commit -a --amend -s
git push --force

@TomSweeneyRedHat
Copy link
Member

LGTM
once gating issues are solved per @rhatdan's comment

Fixes containers#7509. There is no need to create a ~/.config directory now that
~/.config/containers/storage.conf is not created automatically. Podman
has no use for it if it does not exist already.

Signed-off-by: jjzmajic <[email protected]>
@cyruseuros
Copy link
Contributor Author

Sorry about that @rhatdan, @TomSweeneyRedHat. Better now?

@rhatdan
Copy link
Member

rhatdan commented Sep 2, 2020

/approve
/lgtm
Thanks again @jjzmajic

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjzmajic, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1184cdf into containers:master Sep 2, 2020
@cyruseuros
Copy link
Contributor Author

cyruseuros commented Sep 3, 2020

@rhatdan, @TomSweeneyRedHat, quick question: We need to package a new version of podman and I figured this fix might as well be included since we're not in a rush. Best guess as to when the next patch version of podman will be released?

@mheon
Copy link
Member

mheon commented Sep 3, 2020 via email

@cyruseuros
Copy link
Contributor Author

Ohhh, didn't know you were getting ready to bump the minor version too. Thanks @mheon! Best of luck!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic creation of storage.conf/libpod.conf is an anti-feature
6 participants