Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Making docs build on mac #7457

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Conversation

ashley-cui
Copy link
Member

sed syntax on mac is different

Signed-off-by: Ashley Cui [email protected]

@mheon
Copy link
Member

mheon commented Aug 26, 2020

LGTM

@@ -88,21 +88,30 @@ function pub_pages() {
done
}

## sed syntax is different on darwin and linux
function sed_os(){
if [[ "$OSTYPE" == "darwin"* ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When possible, I like to test for functionality rather than platform. Is there a way to, say, run sed --help and differentiate the Mac version from regular sed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sed --help doesn't work on a mac so i can base it off of the exit code for sed --help ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really alarming! But yes, I think it would be safe to correlate "sed --help fails" with "this is not GNU sed, therefore it needs a special invocation of -i".

@edsantiago
Copy link
Member

Oops! Forgot to mention: if you edit the PR title, adding [CI:DOCS], you receive a get-out-of-CI-hell-free card. I don't know if you also need to change the subject of your git commit, but if you're going to re-push, might as well.

@ashley-cui ashley-cui changed the title Making docs build on mac [CI:DOCS] Making docs build on mac Aug 26, 2020
sed syntax on mac is different

Signed-off-by: Ashley Cui <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons

@rhatdan
Copy link
Member

rhatdan commented Aug 26, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@ashley-cui
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@ashley-cui
Copy link
Member Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@TomSweeneyRedHat
Copy link
Member

@ashley-cui close, next time try
/hold cancel

@rhatdan rhatdan merged commit 7d3cadc into containers:master Aug 27, 2020
@ashley-cui ashley-cui deleted the macdocs branch October 12, 2020 13:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants