-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Making docs build on mac #7457
Conversation
LGTM |
docs/remote-docs.sh
Outdated
@@ -88,21 +88,30 @@ function pub_pages() { | |||
done | |||
} | |||
|
|||
## sed syntax is different on darwin and linux | |||
function sed_os(){ | |||
if [[ "$OSTYPE" == "darwin"* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When possible, I like to test for functionality rather than platform. Is there a way to, say, run sed --help
and differentiate the Mac version from regular sed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sed --help
doesn't work on a mac so i can base it off of the exit code for sed --help
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really alarming! But yes, I think it would be safe to correlate "sed --help fails" with "this is not GNU sed, therefore it needs a special invocation of -i".
Oops! Forgot to mention: if you edit the PR title, adding |
sed syntax on mac is different Signed-off-by: Ashley Cui <[email protected]>
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/unhold |
@ashley-cui close, next time try |
sed syntax on mac is different
Signed-off-by: Ashley Cui [email protected]