Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test comment for now-succeeding tests #7438

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

saschagrunert
Copy link
Member

The related issue seems fixed so the test execution should work as intended.

The related issue seems fixed so the test execution should work as
intended.

Signed-off-by: Sascha Grunert <[email protected]>
@edsantiago edsantiago changed the title Remove test comment for now succeeding tests Remove test comment for now-succeeding tests Aug 25, 2020
@edsantiago
Copy link
Member

LGTM, nice catch

@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@mheon
Copy link
Member

mheon commented Aug 25, 2020

/hold
CI is red

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2020

Sadly totally unrelated to this PR.

@edsantiago
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 26, 2020

/retry

@rhatdan rhatdan merged commit d6b0377 into containers:master Aug 27, 2020
@saschagrunert saschagrunert deleted the comment branch August 27, 2020 11:58
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants