Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just use rm for helper command to remove storage #7437

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Just use rm for helper command to remove storage #7437

merged 1 commit into from
Sep 6, 2020

Conversation

saschagrunert
Copy link
Member

This allows to use any kind of rm in $PATH for the system tests.

@mheon
Copy link
Member

mheon commented Aug 25, 2020

LGTM

@mheon
Copy link
Member

mheon commented Aug 25, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
edsantiago
edsantiago reviewed Aug 25, 2020
View reviewed changes
test/system/helpers.bash
@@ -67,7 +67,7 @@ function basic_teardown() {
run_podman '?' pod rm --all --force
run_podman '?' rm --all --force

/bin/rm -rf $PODMAN_TMPDIR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention here was to override a possible rm alias. We once had CI break because of that (on this project), and pretty much everyone has hit that problem at least once in their career. I might feel more comfortable with command rm; but it's probably not worth incurring the wrath of CI to resubmit.

I know you must get this a lot, but it's really offensive for a distro to break fifty years of UNIX /bin precedent. I'm not blaming you, I know you're trying to work with the framework you have. I just need to vent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I changed it to $(command -v rm) …, I think this would also work if one has set an alias for rm. 😇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why not just command rm? $(command -v rm) seems overly rococo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, fixed that too 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just to \rm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just to \rm

@saschagrunert saschagrunert force-pushed the rm branch 2 times, most recently from 069cb73 to 900f5cd Compare August 25, 2020 14:14
@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
but rootless testing isn't hip, likely a known flake

@edsantiago
Copy link
Member

@TomSweeneyRedHat yes, it's #7195, I'm spending my day pressing Re-run on this and other PRs.

@mheon
Copy link
Member

mheon commented Aug 25, 2020

/hold
CI is red

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 28, 2020

@saschagrunert Please rebase to fix flakes.

@saschagrunert
Just use rm for helper command to remove storage
773bbff 
This allows to use any kind of `rm` in `$PATH` for the system tests.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@saschagrunert
Copy link
Member Author

@saschagrunert Please rebase to fix flakes.

Yes, rebased on top of the latest master branch.

@rhatdan
Copy link
Member

rhatdan commented Sep 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@rhatdan
Copy link
Member

rhatdan commented Sep 6, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit ba8d0bb into containers:master Sep 6, 2020
@saschagrunert saschagrunert deleted the rm branch September 6, 2020 11:47
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan left review comments

@edsantiago edsantiago edsantiago left review comments

@baude baude Awaiting requested review from baude

@mheon mheon Awaiting requested review from mheon

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @mheon @openshift-ci-robot @rhatdan @TomSweeneyRedHat @edsantiago @openshift-merge-robot