Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv2 test: add more tests for containers #7426

Merged

Conversation

Edward5hen
Copy link
Contributor

Tests covering:
container exists
container pause
container unpause
container top
container mount
container unmount

@TomSweeneyRedHat
Copy link
Member

@Edward5hen thanks for the contribution! Our CI requires that the commits be signed. Please do git commit --amend-s, rebase and repush your commit. In addition, it looks like lint is not too happy with this either, please check the failed gating test for more information.

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move these into a new file? 20-containers.at has grown enormous. This makes it very painful to diagnose individual failures. Thank you.

Also, @baude @jwhonce @mheon, why on Earth do we have a remote endpoint for mount?

@mheon
Copy link
Member

mheon commented Aug 24, 2020

@baude wanted it - intended for use cases where podman-remote and podman system service are on the same machine, I think?

@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2020

I have no idea on why we have this for mount, (Which means someone will remind me, why I wanted it)

@Edward5hen Edward5hen force-pushed the apiv2-containers-test branch 2 times, most recently from 0301e40 to f11fd76 Compare August 27, 2020 09:38
@Edward5hen
Copy link
Contributor Author

@TomSweeneyRedHat @edsantiago PTAL

@TomSweeneyRedHat
Copy link
Member

@Edward5hen changes LGTM, but I think you'll need to rebase to clear up the test issue. A PR went in very recently that should hopefully fix that once rebased.

@Edward5hen Edward5hen force-pushed the apiv2-containers-test branch from f11fd76 to 43ad9be Compare September 1, 2020 08:02
@Edward5hen
Copy link
Contributor Author

Edward5hen commented Sep 1, 2020

@TomSweeneyRedHat rebase is done, but fail some tests. I've no idea why they got "IO error" and "Remote host terminated the handshake". Could you please help check? Thanks.

@edsantiago
Copy link
Member

@Edward5hen those were Cirrus flakes. Pressing Re-run made them pass.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@rhatdan
Copy link
Member

rhatdan commented Sep 2, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Edward5hen, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 96079e2 into containers:master Sep 2, 2020
@Edward5hen Edward5hen deleted the apiv2-containers-test branch September 10, 2020 02:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants