-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIv2 test: add more tests for containers #7426
APIv2 test: add more tests for containers #7426
Conversation
@Edward5hen thanks for the contribution! Our CI requires that the commits be signed. Please do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baude wanted it - intended for use cases where |
I have no idea on why we have this for mount, (Which means someone will remind me, why I wanted it) |
0301e40
to
f11fd76
Compare
@Edward5hen changes LGTM, but I think you'll need to rebase to clear up the test issue. A PR went in very recently that should hopefully fix that once rebased. |
Signed-off-by: Edward Shen <[email protected]>
f11fd76
to
43ad9be
Compare
@TomSweeneyRedHat rebase is done, but fail some tests. I've no idea why they got "IO error" and "Remote host terminated the handshake". Could you please help check? Thanks. |
@Edward5hen those were Cirrus flakes. Pressing Re-run made them pass. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Edward5hen, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests covering:
container exists
container pause
container unpause
container top
container mount
container unmount