fix apiv2 will create containers with incorrect commands

[zhangguanzhang]

Fixes: #7235 (comment)

$  podman inspect docker.io/zhangguanzhang/travis --format '{{.Config.Entrypoint}}'
[travis]

use the apiv2 to create the container

$  podman system  service --time 0 tcp:127.0.0.1:8081 &
$ curl http://localhost:8081/v1.40/containers/create?name=test-api2 -X POST \
  -H "Content-Type: application/json" \
  --data '{"Image":"docker.io/zhangguanzhang/travis","Cmd":["echo","param1"]}'

check the output

$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Path
"" <--- wrong, should be `travis`
$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Args
null <--- wrong, should be `["echo","param1"]`

and run command is incorrect

$ podman start test-api2
test-api2
$ podman logs test-api2
param1

if not use apiv2 to run this

$ podman container create --name cli-run  docker.io/zhangguanzhang/travis echo param1
$ podman start cli-run
cli-run
$ podman logs cli-run
unknown command echo <-- it will run `travis echo param1`, it is correct

after fix

$ ./bin/podman system  service --time 0 tcp:127.0.0.1:8081 &
$ curl http://localhost:8081/v1.40/containers/create?name=test-api2 \
  -X POST -H "Content-Type: application/json"\
   --data '{"Image":"docker.io/zhangguanzhang/travis","Cmd":["echo","param1"]}'
$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Config.Entrypoint
[
  "travis"
]
$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Config.Cmd
[
  "echo",
  "param1"
]
$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Path
"travis"
$ curl -s http://localhost:8081/v1.40/containers/test-api2/json | jq .Args
[
  "echo",
  "param1"
]
$ 

Signed-off-by: zhangguanzhang [email protected]

[TomSweeneyRedHat]

The tests are failing with a real failure.

[mheon]

I don't think this is correct - we should not use image command if entrypoint was set by the user. This check needs to be above the c.config.Entrypoint == nil check about to make sense.

[zhangguanzhang]

I don't think this is correct - we should not use image command if entrypoint was set by the user. This check needs to be above the c.config.Entrypoint == nil check about to make sense.

thanks for reminding

[TomSweeneyRedHat]

Maybe I've not had a enough tea today, but the comment doesn't seem to match the code? I'm not sure we want this change....

[zhangguanzhang]

Or to put it another way, we only consider setting Cmd when entrypoint is not set by the user

[TomSweeneyRedHat]

OK, maybe we could shorten lines 486->488 to:

Set CMD in the container to the default configuration only if ENTRYPOINT is not set by the user.

I think that better describes it, thoughts?

[zhangguanzhang]

It had done,but I only changed the comment. after this, the ci reported an error. . .

[TomSweeneyRedHat]

I've restarted the test. I think it's an intermittent CI error that @edsantiago has been chasing.

[zhangguanzhang]

thanks

[zhangguanzhang]

The general idea is fine, but there are some detailed problems in the CI, I will try to fix them

[zhangguanzhang]

@mheon @TomSweeneyRedHat PTAL

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhangguanzhang]

I only changed the comment, but ci reported an error. . .

[QiWang19]

LGTM

[QiWang19]

@mheon @TomSweeneyRedHat PTAL

[TomSweeneyRedHat]

LGTM, but would like @mheon to review to ensure his concern was addressed.

[TomSweeneyRedHat]

and happy green test buttons fwiw.

[mheon]

/lgtm