Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove help/usage from --remote pre-check #7358

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Aug 18, 2020

--remote pre-check was providing usage context, which was also being
provided by the root podman command.

Fixes #7273

Signed-off-by: Jhon Honce [email protected]

--remote pre-check was providing usage context, which was also being
provided by the root podman command.

Fixes containers#7273

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2020
@jwhonce jwhonce self-assigned this Aug 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pulled & compiled, tested with ./bin/podman help and --help, output is now correct. I've got a BATS test for it, will submit as part of a later set of test updates. Thank you!

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit c1fef2a into containers:master Aug 18, 2020
@jwhonce jwhonce deleted the issues/7273 branch June 30, 2021 16:09
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman --help: spurious "Usage of remote" in stderr
5 participants