Ensure DefaultEnvVariables is used in Specgen #7343
Conversation
openshift-ci-robot
added
the
approved
cmd/podman/common/specgen.go
Outdated
| env := map[string]string{ | ||
| "container": "podman", | ||
| } | ||
| env := envLib.DefaultEnvVariables() |
There was a problem hiding this comment.
It should be getting these fields from containers/common
There was a problem hiding this comment.
We can change that in a future release; for now, we need this merged so we can get it in 2.0.5
There was a problem hiding this comment.
Refactored a bit.
I don't think these make sense for containers.conf, we want to ensure a few basic environment variables are always populated - the user shouldn't really need to ever set this, outside of the existing Env section of containers.conf.
mheon
force-pushed
the
update_defaultenv
branch
2 times, most recently
from
20cc2b3 to
24a74c8
Compare
There was a problem hiding this comment.
LGTM
assuming there's a jira card or podman issue for doing the work that @rhatdan was asking for.
When we rewrote Podman's pkg/spec, one of the things that was lost was our use of a set of default environment variables, that ensure all containers have at least $PATH and $TERM set. While we're in the process of re-adding it, change it from a variable to a function, so we can ensure the Join function does not overwrite it and corrupt the defaults. Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
update_defaultenv
branch
from
24a74c8 to
a7e864e
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
When we rewrote Podman's pkg/spec, one of the things that was lost was our use of a set of default environment variables, that ensure all containers have at least $PATH and $TERM set.
While we're in the process of re-adding it, change it from a variable to a function, so we can ensure the Join function does not overwrite it and corrupt the defaults.