Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system tests: enable sdnotify tests #7317

Merged
merged 1 commit into from
Aug 17, 2020
Merged

system tests: enable sdnotify tests #7317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/system/260-sdnotify.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@ _SOCAT_LOG=
function setup() {
skip_if_remote

# TODO: remove this once CI systems have newer crun and container-selinux
skip "TEMPORARY SKIP - until CI systems get new crun, container-selinux"
# Skip if systemd is not running
systemctl list-units &>/dev/null || skip "systemd not available"

# sdnotify fails with runc 1.0.0-3-dev2 on Ubuntu. Let's just
# assume that we work only with crun, nothing else.
run_podman info --format '{{ .Host.OCIRuntime.Name }}'
if [[ "$output" != "crun" ]]; then
skip "this test only works with crun, not '$output'"
fi

basic_setup
}
Expand Down Expand Up @@ -107,7 +114,7 @@ function _assert_mainpid_is_conmon() {
@test "sdnotify : container" {
# Sigh... we need to pull a humongous image because it has systemd-notify.
# FIXME: is there a smaller image we could use?
_FEDORA=registry.fedoraproject.org/fedora:latest
_FEDORA=registry.fedoraproject.org/fedora:31

# Pull that image. Retry in case of flakes.
run_podman pull $_FEDORA || \
Expand Down