Allow users to override all storage options at the command line

[rhatdan]

podman --root /var/lib/shared --storage-opt="" pull alpine

Tells podman to ignore the storage options defined in storage.conf.

This would allow users to configure additional stores, and still use
podman to update the additional store storage.

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Fixes: #7309

[TomSweeneyRedHat]

A test would be good.
Otherwise LGTM

[mheon]

Concur that a test would be nice

[rhatdan]

The problem is there is no good way to test with storage.conf that I can see, without overwriting the system configuration files.
@edsantiago Any ideas? We basically need a system wide storage.conf with storage-opt set, and then we need to test that this
podman --storage-opt "" info --format "{{.Store.GraphOptions}}"
Ends up equal to "".

[edsantiago]

I was just looking at this PR and pondering that very question. I've long wanted a way to test config files, but really the only sane way to do that is with a --config-file-path=xxx command-line option. With rootless it could be possible to override by redefining $HOME or $XDG_SOMETHING`, but that would have cascading effects because of image/container storage.

For a case like this, where you don't need podman run or anything that actually uses images, I think you could:

@test ..... {
    fake_conf=$PODMAN_TMPDIR/home/.config/containers/containers.conf
    mkdir -[ $(dirname $fake_conf)
    cat >$fake_conf <<EOF
blah blah blah
EOF

    HOME=$PODMAN_TMPDIR/home run_podman --storage-opt="" info ...

Disclaimer: I typed code directly into a browser without testing. That is always a bad idea.

[rhatdan]

Sadly this PR will only work for rootfull podman

[rhatdan]

Need containers/common#262 in order to add tests.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[vrothberg]

@rhatdan, let's get things moving before we the PR has birthday :)

[openshift-ci-robot]

@rhatdan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhatdan]

I have fixed this via other means.

[adamish]

Another possible solution could be podman providing a command that modified the storage.conf file in a safe and consistent way, something like

podman conf add-additionalimagestore "/foo"
podman conf remove-additionalimagestore "/foo"

[rhatdan]

That would be a very complex tool and would need to be modified each time a new config entry was added to containers.conf. If there was a simple way to autogenerate the tool, I might consider it. but this seems like you are building a toml editor.