Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 default route #7314

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Aug 13, 2020

The networking configuration was assuming always that the default
gateway was 0.0.0.0/0, that does not work if we have IPv6
containers.

We must generate the corresponding default route depending of the
IP family of the subnet used.

Signed-off-by: Antonio Ojea [email protected]

@aojea
Copy link
Contributor Author

aojea commented Aug 13, 2020

/assign @mheon @mrunalp

This allows to create IPv6 clusters with KIND

NAME                 STATUS   ROLES    AGE    VERSION   INTERNAL-IP              EXTERNAL-IP   OS-IMAGE           KERNEL-VERSION           CONTAINER-RUNTIME
kind-control-plane   Ready    master   4m9s   v1.18.6   fc00:681e:5d82:3c05::2   <none>        Ubuntu 20.04 LTS   5.7.10-201.fc32.x86_64   containerd://1.4.0-beta.1-85-g334f567e

go.mod Outdated Show resolved Hide resolved
pkg/network/netconflist.go Outdated Show resolved Hide resolved
pkg/network/netconflist.go Outdated Show resolved Hide resolved
@aojea aojea force-pushed the ipv6_default_gw branch 3 times, most recently from eb75757 to 66cc1e2 Compare August 14, 2020 09:20
@aojea
Copy link
Contributor Author

aojea commented Aug 14, 2020

@mheon PTAL, I've removed the dependencies, kept the same signature for NewIPAMDefaultRoute and added an e2e test

podman containers using IPv6 were missing the default route, breaking
deployments trying to use them.

The problem is that the default route was hardcoded to IPv4, this
takes into consideration the podman subnet IP family to generate
the corresponding default route.

Signed-off-by: Antonio Ojea <[email protected]>
@aojea
Copy link
Contributor Author

aojea commented Aug 15, 2020

/retest

@openshift-ci-robot
Copy link
Collaborator

@aojea: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mheon
Copy link
Member

mheon commented Aug 15, 2020

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2020
@rhatdan
Copy link
Member

rhatdan commented Aug 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 96fb5dc into containers:master Aug 16, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants