Makefile: use full path for ginkgo

[lsm5]

Without this change, I get:

ginkgo \
        -r \
         \
        --skipPackage test/e2e,pkg/apparmor,test/endpoint,pkg/bindings,hack \
        --cover \
        --covermode atomic \
        --coverprofile coverprofile \
        --outputdir .coverage \
        --tags "   selinux systemd exclude_graphdriver_devicemapper seccomp" \
        --succinct
/bin/sh: line 1: ginkgo: command not found

Signed-off-by: Lokesh Mandvekar [email protected]

Btw, I have only encountered this issue for the command mentioned above, but I made similar changes to other lines as well where ginkgo was used.

@edsantiago @rhatdan PTAL

[rhatdan]

LGTM

[TomSweeneyRedHat]

LGTM

[jwhonce]

Pending tests
/hold
/lgtm

[edsantiago]

One flake was #7148, the dreaded cgroups.freeze one. The other (on podman-remote) was the one I'm calling #7195, where server gets cranky and stops talking to client.

[lsm5]

@rhatdan I see this in https://cirrus-ci.com/task/4939064006672384

[+0168s] not ok 93 podman selinux: container with overridden range
[+0168s] # (from function `is' in file test/system/helpers.bash, line 330,
[+0168s] #  from function `check_label' in file test/system/410-selinux.bats, line 25,
[+0168s] #  in test file test/system/410-selinux.bats, line 56)
[+0168s] #   `check_label "--security-opt label=level:s0:c1,c2" "container_t" "s0:c1,c2"' failed
[+0168s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman-remote --url unix:/tmp/podman.ujULYA rm --all --force
[+0168s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman-remote --url unix:/tmp/podman.ujULYA images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
[+0168s] # quay.io/libpod/alpine_labels:latest 4fab981df737
[+0168s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman-remote --url unix:/tmp/podman.ujULYA run --rm --security-opt label=level:s0:c1,c2 quay.io/libpod/alpine_labels:latest cat -v /proc/self/attr/current
[+0168s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0168s] # #|     FAIL: SELinux role should always be system_r
[+0168s] # #| expected: '.*_u:system_r:.*'
[+0168s] # #|   actual: ''
[+0168s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[edsantiago]

@lsm5 that's a flake, probably #7195

[lsm5]

@jwhonce looking good ??

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/hold cancel