Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Status field in the ps --format=json #7261

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add the Status field in the ps --format=json #7261

merged 1 commit into from
Aug 11, 2020

Conversation

zhangguanzhang
Copy link
Collaborator

Signed-off-by: zhangguanzhang [email protected]
Fixes: #6980

@zhangguanzhang zhangguanzhang force-pushed the ps-format-add-field branch 3 times, most recently from f075ecd to 108fe0c Compare August 8, 2020 12:28
@rhatdan
Copy link
Member

rhatdan commented Aug 8, 2020

LGTM

@TomSweeneyRedHat
Copy link
Member

All kinds of test timeout and unable to remove container errors in the CI tests. I'm not sure how this change would do that.

@zhangguanzhang
Copy link
Collaborator Author

zhangguanzhang commented Aug 9, 2020 •
edited
Loading

All kinds of test timeout and unable to remove container errors in the CI tests. I'm not sure how this change would do that.

[+0215s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman-remote --url unix:/tmp/podman.nUsXlU wait f99281f82ea12b5d50e5374a5925dd48f96f09e4f42c4bb50df939c3860f6b13
[+0215s] # timeout: sending signal TERM to command ‘/var/tmp/go/src/github.com/containers/podman/bin/podman-remote’
[+0215s] # [ rc=124 (** EXPECTED 0 **) ]

These lines did not work as expected for some reason https://github.com/containers/podman/blob/master/test/system/075-exec.bats#L31-L33
Could come here to discuss this issue #7241

@edsantiago
Copy link
Member

@zhangguanzhang please rebase on master, to fix the constantly-failing CI errors. I am sorry about the inconvenience.

@zhangguanzhang zhangguanzhang force-pushed the ps-format-add-field branch 2 times, most recently from ab652ac to ead21f8 Compare August 11, 2020 03:49
@zhangguanzhang
Copy link
Collaborator Author

@vrothberg PTAL

vrothberg
vrothberg reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@vrothberg
Copy link
Member

Thanks, @zhangguanzhang !

@zhangguanzhang zhangguanzhang added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a90ae00 into containers:master Aug 11, 2020
@zhangguanzhang zhangguanzhang deleted the ps-format-add-field branch August 28, 2020 02:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output of podman ps --format=json
7 participants
@zhangguanzhang @rhatdan @TomSweeneyRedHat @edsantiago @vrothberg @openshift-ci-robot @openshift-merge-robot