fix podman logs --tail when log is bigger than pagesize #7232
Conversation
Luap99
force-pushed
the
podman-logs-tail
branch
from
ac12a2f to
bf13242
Compare
| @@ -61,6 +61,6 @@ func (r *ReverseReader) Read() (string, error) { | |||
| b = b[0:n] | |||
| } | |||
| // Set to the next page boundary | |||
| r.offset = -r.readSize | |||
| r.offset -= r.readSize | |||
There was a problem hiding this comment.
let's adjust the comment to reflect what is done now
|
LGTM with @giuseppe comment. |
|
New test also seems to be failing |
|
LGTM |
Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
podman-logs-tail
branch
from
bf13242 to
2c79f99
Compare
|
OK, I updated the code. Tests were failing due an race condition were the file was closed to early. Should be fixed now. |
| @@ -101,11 +101,14 @@ func getTailLog(path string, tail int) ([]*LogLine, error) { | |||
| if err != nil { | |||
| if errors.Cause(err) == io.EOF { | |||
| inputs <- []string{leftover} | |||
| close(inputs) | |||
There was a problem hiding this comment.
Is this close done somewhere else? Is it not needed?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Fixes #7230