Handle podman-remote run --rm

[rhatdan]

We need to remove the container after it has exited for
podman-remote run --rm commands. If we don't remove this
container at this step, we open ourselves up to race conditions.

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@edsantiago @mheon PTAL

[edsantiago]

Is this intended to fix #7119? If so could you grep 7119 test/system/*.bats and remove all matching lines?

[mheon]

LGTM

[edsantiago]

Flake in special_testing_rootless:

 $ podman-remote --url unix:/tmp/podman.Hu25Ai run --rm quay.io/libpod/alpine_labels:latest cat -v /proc/self/attr/current
[+0224s] # read unixpacket @->/run/user/14096/libpod/tmp/socket/32f534034d29cb66f3d3d341a7ddbec1bb13244ee426497a2ffed12579e4f1fb/attach: read: connection reset by peer

I saw that on one CI run in #7111 but was unable to reproduce it (despite a lot of effort) hence did not file an issue.

The socket in question is a conmon one, not the podman-remote socket. I suspect there is a troublesome interaction between conmon and podman-remote but I don't know how to even file an issue without a reproducer.

[edsantiago]

LGTM but (if this really is intended as a fix for #7119) I'd really like those tests enabled

[edsantiago]

FWIW I pulled the PR, removed the 7119 skips from bats tests, and let them run. Root and rootless, seven runs each over an hour or so, no failures. That inspires confidence.

In case it helps:

$ perl -i -ne 'print unless /7119/' test/system/*bats

[rhatdan]

Fixes: #7119

[TomSweeneyRedHat]

LGTM
assuming happy tests

[edsantiago]

CI passed all in one go, no flakes.

/lgtm