Improve error message when creating a pod/ctr with the same name #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Luap99
force-pushed
the
pod/ctr-exists-error
branch
2 times, most recently
from
59d07af to
25f98f9
Compare
Check if there is an pod or container an return the appropriate error message instead of blindly return 'container exists' with `podman create` and 'pod exists' with `podman pod create`. Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
pod/ctr-exists-error
branch
from
25f98f9 to
97b2b07
Compare
|
LGTM |
mheon
reviewed
Aug 4, 2020
| if allPodsBkt.Get(idExist) == nil { | ||
| err = define.ErrCtrExists | ||
| } | ||
| return errors.Wrapf(err, "ID \"%s\" is in use", pod.ID()) |
There was a problem hiding this comment.
For reference, %q produces the same output as \"%s\" - but since they're identical, there's no real need to change it.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there is an pod or container an return
the appropriate error message instead of blindly
return 'container exists' with
podman createand'pod exists' with
podman pod create.Example: