API returns 500 in case network is not found instead of 404 #7188
Conversation
zhangguanzhang
force-pushed
the
network-404
branch
2 times, most recently
from
c87ad9a to
902184b
Compare
pkg/api/handlers/compat/networks.go
Outdated
| @@ -2,6 +2,7 @@ package compat | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "github.com/containers/podman/v2/libpod/define" | |||
There was a problem hiding this comment.
looks like this should go in the batch that starts on line 13
pkg/api/handlers/libpod/networks.go
Outdated
| @@ -2,13 +2,13 @@ package libpod | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "github.com/containers/podman/v2/libpod/define" | |||
There was a problem hiding this comment.
looks like this should go in the batch that starts on line 8
pkg/network/files.go
Outdated
| @@ -3,6 +3,7 @@ package network | |||
| import ( | |||
| "encoding/json" | |||
| "fmt" | |||
| "github.com/containers/podman/v2/libpod/define" | |||
There was a problem hiding this comment.
looks like this should go in the batch that starts on line 13
pkg/network/network.go
Outdated
| @@ -2,6 +2,7 @@ package network | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "github.com/containers/podman/v2/libpod/define" | |||
There was a problem hiding this comment.
looks like this should go in the batch that starts on line 11
test/apiv2/35-networks.at
Outdated
|
|
||
| t GET /networks/non-existing-network 404 | ||
|
|
||
| # vim: filetype=sh |
Signed-off-by: zhangguanzhang <[email protected]>
zhangguanzhang
force-pushed
the
network-404
branch
from
902184b to
45b100d
Compare
|
@orenbm thanks |
|
@vrothberg PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| @@ -20,10 +19,6 @@ const ( | |||
| DefaultPodmanDomainName = "dns.podman" | |||
| ) | |||
|
|
|||
| var ( | |||
| ErrNetworkNotFound = errors.New("network not found") | |||
There was a problem hiding this comment.
This should have been left and just a redirect to define.ErrNetowrkNotFound, otherwise you are changing the API.
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: zhangguanzhang [email protected]
Fixes: #7184