implement the exitcode when start a container with attach

[zhangguanzhang]

Signed-off-by: zhangguanzhang [email protected]
Fixes: #7150
will be ok if use the docker

[root@centos7 ~]# docker create --name test --entrypoint=sh alpine:3.12 -c 'exit 1'
4dbc2dc4355a754a62a16910a3037578b1efa83d07d63889c1fd773b3c974d8a
[root@centos7 ~]# docker start -a test
[root@centos7 ~]# echo $?
1
[root@centos7 ~]# 

before and after fix

[root@sz-test podman]# podman create --name test --entrypoint=sh docker.io/library/alpine:3.12 -c 'exit 1'
59694fc44140e81ddc9c2beaaec9613a689a6ccebf29a09c2e3f749a389f5088
[root@sz-test podman]# podman start -a test
[root@sz-test podman]# echo $?
0
[root@sz-test podman]# ./bin/podman start -a test
[root@sz-test podman]# echo $?
1

[rhatdan]

Could you add a test for this?

[mheon]

LGTM

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

e2e or both.

[TomSweeneyRedHat]

nit/personal bias: I know it's not followed stringently, but I prefer that the full option to be spelled out in the test so there's no doubt what's being run.

Suggested change

	session = podmanTest.Podman([]string{"start", "-a", cid})
	session = podmanTest.Podman([]string{"start", "--attach", cid})

[zhangguanzhang]

I will change it

[TomSweeneyRedHat]

LGTM
Thanks @zhangguanzhang !

[rhatdan]

/lgtm
/hold
Great work @zhangguanzhang

[rhatdan]

/hold cancel