Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Add python packages to images #7138

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Cirrus: Add python packages to images #7138

merged 3 commits into from
Aug 10, 2020

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 29, 2020 •
edited
Loading

Python packages per @jwhonce request and Ubuntu 19.10 golang 1.13 for @rhatdan in buildah (per containers/buildah#2462 (comment) )

Signed-off-by: Chris Evich [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020
@cevich cevich force-pushed the add_python_packages branch 5 times, most recently from 9692cb8 to 22ab5a7 Compare July 30, 2020 14:25
@cevich cevich mentioned this pull request Jul 30, 2020
Merged
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Add python packages to images Cirrus: Add python packages to images Jul 30, 2020
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 30, 2020
@cevich cevich force-pushed the add_python_packages branch from 0d3b8bc to 26d88b2 Compare July 30, 2020 16:17
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@rhatdan
Copy link
Member

rhatdan commented Jul 30, 2020

LGTM
/approve
@vrothberg @mheon @TomSweeneyRedHat @jwhonce @ashley-cui @QiWang19 @edsantiago PTAL

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@edsantiago
Copy link
Member

Is this for test/apiv2/rest_api? Did you verify (is there a way to verify) if those tests run on the new VMs? I have a vague memory that the python tests required some sort of docker.py package -- @jwhonce is that no longer the case?

@cevich
Copy link
Member Author

cevich commented Jul 30, 2020

Is this for test/apiv2/rest_api?

Yes...@jwhonce needs to take a look. Possibly play / confirm his stuff works in a hack/get_ci_vm.sh fedora-31-podman-6530021898584064 (assuming if it works in 31, it'll work in 32)

@cevich
Copy link
Member Author

cevich commented Jul 31, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
cevich added 3 commits July 31, 2020 10:10
@cevich
Cirrus: Add python packages to images
543606c 
They are needed in support of future testing additions.

Also reduce unnecessary output by not printing the downloaded package
list.  The set can be examined using other tooling if/when necessary.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Cirrus: Install golang 1.14 on Ubuntu
ba4a1e6 
This more/less reverts efd1422 + updates to 1.13
on all Ubuntus for all `containers` projects.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Cirrus: Utilize freshly built images
b9f477a 
Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the add_python_packages branch from 26d88b2 to b9f477a Compare July 31, 2020 14:10
@cevich
Copy link
Member Author

cevich commented Jul 31, 2020

Force-pushed just comment updates. Would like the final /lgtm from @jwhonce to confirm these are the only python modules needed.

@cevich cevich requested a review from jwhonce July 31, 2020 14:12
@jwhonce
Copy link
Member

jwhonce commented Aug 3, 2020

@cevich No joy running the hack script:

.
:
ERROR: (gcloud.compute.ssh) Could not fetch resource:
 - The resource 'projects/libpod-218412/zones/us-central1-a/instances/jhonce-fedora-31-podman-6530021898584064' was not found
:
.
The following instances will be deleted. Any attached disks configured
 to be auto-deleted will be deleted unless they are attached to any 
other instances or the `--keep-disks` flag is given and specifies them
 for keeping. Deleting a disk is irreversible and any data on the disk
 will be lost.
 - [jhonce-fedora-31-podman-6530021898584064] in [us-central1-a]

Do you want to continue (Y/n)?  y

ERROR: (gcloud.compute.instances.delete) Failed to fetch some instances:
 - The resource 'projects/libpod-218412/zones/us-central1-a/instances/jhonce-fedora-31-podman-6530021898584064' was not found

Has fedora-31-podman-6530021898584064 changed? How can I find the latest value?

@cevich
Copy link
Member Author

cevich commented Aug 5, 2020

@jwhonce how are we lookin' here?

@jwhonce
Copy link
Member

jwhonce commented Aug 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@cevich
Copy link
Member Author

cevich commented Aug 10, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 162625f into containers:master Aug 10, 2020
@cevich cevich deleted the add_python_packages branch June 30, 2021 18:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cevich @rhatdan @openshift-ci-robot @edsantiago @jwhonce @openshift-merge-robot