[CI:DOCS] apiv2 fix volumes not included field #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheon
reviewed
Jul 27, 2020
pkg/domain/entities/volumes.go
Outdated
|
|
||
| // List of volumes | ||
| // Required: true | ||
| Volumes VolumeInfo `json:"Volumes"` |
mheon
reviewed
Jul 27, 2020
pkg/domain/entities/volumes.go
Outdated
| // Required: true | ||
| Scope string `json:"Scope"` | ||
|
|
||
| // Low-level details about the volume, provided by the volume driver. |
There was a problem hiding this comment.
It's completely omitted in Podman for now, we should mention this.
mheon
reviewed
Jul 27, 2020
mheon
reviewed
Jul 27, 2020
mheon
reviewed
Jul 27, 2020
pkg/domain/entities/volumes.go
Outdated
| // Required: true | ||
| Options map[string]string `json:"Options"` | ||
|
|
||
| // The level at which the volume exists. Either `global` for cluster-wide, or `local` for machine level. |
There was a problem hiding this comment.
This is always set to "local" for Podman, we do not support global volumes (they're a swarm thing)
jwhonce
changed the title
QiWang19
force-pushed
the
usagedate
branch
3 times, most recently
from
65ffa2a to
0e5fd12
Compare
Do not use volume from docker since UsageData field is not need. It's nullable in docker API and expensive to add. Signed-off-by: Qi Wang <[email protected]>
|
Should this PR really have the |
|
LGTM once @mheon 's concerns are addressed. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use volume from docker since UsageData field is not need. It's nullable in docker API and expensive to add.
Signed-off-by: Qi Wang [email protected]