Lower missing runtime from Errorf to Infof #7077
Conversation
Creating a container with --runtime=... Can cause a situation where all of the tools that look at containers starts generating an ugly error message that does not effect the running of the tool, but gives the users a bad experience. Also users can not fix this situation easily without removing the container or figuring out how to edit containers.conf. From looking at the problem, it does not look like a real issue and should just be printed at the Info level. Signed-off-by: Daniel J Walsh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
This is actually a serious issue for some commands. There's no way to do a
'podman start' or 'podman kill' or 'podman rm -f' without a working
runtime. We can probably get away with doing this, but the error message
that the missing runtime prints will need to be improved to tell people
what happened and how to fix it
…On Fri, Jul 24, 2020, 08:21 Valentin Rothberg ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7077 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCBT4IX34APLCGN4G2TR5F4CVANCNFSM4PGVAZ2Q>
.
|
|
Should we make it more difficult to get into this state? |
|
I'm thinking that's a good idea. Instead of making a missing runtime if it's not in the config, we can first look it up in $PATH, and if we find it we use it - if not, we fall back to MissingRuntime and the error message. |
|
@mheon Could you take this one over, since you understand what is going on here better then me. |
|
Sure! |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
I think we can close this in favor of #7126 |
github-actions
bot
added
the
locked - please file new issue/PR
Creating a container with --runtime=... Can cause a situation where all of the tools that look at containers starts generating an ugly error message that
does not effect the running of the tool, but gives the users a bad experience.
Also users can not fix this situation easily without removing the container or
figuring out how to edit containers.conf.
From looking at the problem, it does not look like a real issue and should just be printed at the Info level.
Signed-off-by: Daniel J Walsh [email protected]