TODO: Refactor container config

[ldelossa]

This commit handle the TODO task of breaking the Container
config into smaller sub-configs.

Signed-off-by: ldelossa [email protected]

[ldelossa]

/assign @baude

looks like test failed, but a gating test on a file not affiliated with this change.

[rhatdan]

@mheon PTAL

[mheon]

Ah, I think you broke some test functions that want to make Container structs - looks like container_internal_test.go container_internal_linux_test.go and common_test.go will need a few fields renamed.

[ldelossa]

@mheon

Will take a look at fixing 👍

[ldelossa]

@mheon

friendly ping, all tests fixed.

[rhatdan]

@ldelossa needs a rebase.

[ldelossa]

Done. Updated a few Container method comments for completeness along the way.

[mheon]

We really need to do a pass over comments on individual fields in the structs, but that's a lot of work and can happen later.
LGTM once things go green.
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldelossa, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ldelossa]

@mheon As I am just getting acquainted with this code base, if you have an idea of a good starting point for a maintenance task like that, creating an issue and assigning it to me would be welcome on my end.

thanks for approval.

[ldelossa]

looks like all tests passed aside from one, maybe a flake?

[mheon]

[+0261s] # error opening file `/sys/fs/cgroup//system.slice/buildah-buildah715212271-541317.scope/cgroup.freeze`: No such file or directory
[+0261s] # kill container: No such process

Out of a podman build system test.
@edsantiago Is this a known flake?

[edsantiago]

Aaaaargh! Yes, it is. A bug in crun which I had hoped would be fixed in CI after #6822 got merged yesterday.

Looking at the failing results, I see crun-0.13-2.fc31-x86_64 which is the known-bad version. What I can't tell is when this run was made, the timestamp is 11:01:48 but (SIGH) there's no date so I don't know if that was yesterday or today. Is there any chance that the failure happened yesterday? Because that would be good. Or at least OK. If it failed today, I will need to dig a lot deeper into this.

[ldelossa]

@edsantiago

Cirrus CI / test fedora-31 TEST_REMOTE_CLIENT:false started 23m 8s ago

So ~23m ago it failed.

[edsantiago]

No, that's just the time when the test was restarted. It's still running. I'll check it when it finishes.

[ldelossa]

got it, my bad.

[edsantiago]

Test passed, but package versions shows crun 0.13. Looks like crun 0.14 made it only into f32, not f31. I'll pursue that.

[ldelossa]

This good to get merged?

[mheon]

Sure, LGTM.
@rhatdan @vrothberg @giuseppe @TomSweeneyRedHat PTAL

[rhatdan]

Thanks @ldelossa LGTM
/lgtm