Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: system df error when an image has no name #7018

Merged
merged 1 commit into from
Jul 20, 2020
Merged

fix: system df error when an image has no name #7018

merged 1 commit into from
Jul 20, 2020

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 19, 2020 •
edited
Loading

When an image has no name/tag system df will
error because it tries to parse an empty name.

This commit makes sure we only parse non
empty names and set the repository and tag
to "<none>" otherwise.

Closes #7015

Signed-off-by: Paul Holzinger [email protected]

fix: system df error when an image has no name
67a5e21 
When an image has no name/tag system df will
error because it tries to parse an empty name.

This commit makes sure we only parse non
empty names and set the repository and tag
to "<none>" otherwise.

Closes containers#7015

Signed-off-by: Paul Holzinger <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jul 20, 2020

LGTM
@vrothberg @baude @mheon @QiWang19 @ashley-cui @TomSweeneyRedHat PTAL

vrothberg
vrothberg reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vrothberg
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@rhatdan
Copy link
Member

rhatdan commented Jul 20, 2020

@Luap99 Thanks for the submission.

@rhatdan rhatdan added approved Indicates a PR has been approved by an approver from all required OWNERS files. Backport to v2.0 labels Jul 20, 2020
@rhatdan
Copy link
Member

rhatdan commented Jul 20, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 17f9b80 into containers:master Jul 20, 2020
@Luap99 Luap99 deleted the fix#7015 branch January 17, 2021 13:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@giuseppe giuseppe Awaiting requested review from giuseppe

@mheon mheon Awaiting requested review from mheon

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'podman system df' results in Error: invalid reference format
5 participants
@Luap99 @rhatdan @vrothberg @openshift-ci-robot @openshift-merge-robot