Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi: set default umask and rlimits #7005

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

giuseppe
Copy link
Member

the code got lost in the migration to podman 2.0, reintroduce it.

Closes: #6989

Signed-off-by: Giuseppe Scrivano [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@giuseppe giuseppe force-pushed the set-umask-rlimits branch from e1473c6 to 0e8e0a4 Compare July 17, 2020 12:14
@rhatdan
Copy link
Member

rhatdan commented Jul 17, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 17, 2020

Fixes: #6989

@rhatdan
Copy link
Member

rhatdan commented Jul 17, 2020

@giuseppe good catch.

cmd/podman/root.go Outdated Show resolved Hide resolved
@giuseppe giuseppe force-pushed the set-umask-rlimits branch from 0e8e0a4 to 7d32b10 Compare July 17, 2020 14:49
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one non-blocking nit.

cmd/podman/early_init_linux.go Outdated Show resolved Hide resolved
@giuseppe giuseppe force-pushed the set-umask-rlimits branch from 7d32b10 to 32c1ae1 Compare July 17, 2020 18:49
the code got lost in the migration to podman 2.0, reintroduce it.

Closes: containers#6989

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the set-umask-rlimits branch from 32c1ae1 to 65d382d Compare July 17, 2020 18:53
@rhatdan
Copy link
Member

rhatdan commented Jul 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 10c5f24 into containers:master Jul 17, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non root user in docker.io/eclipse-mosquitto container cannot write to any directory under podman 2.0.2
6 participants