Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman system connection panic #6988

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix podman system connection panic #6988

merged 1 commit into from
Jul 16, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Jul 15, 2020

Restored local identity flag

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce self-assigned this Jul 15, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@jwhonce
Copy link
Member Author

jwhonce commented Jul 15, 2020

#6937 closed due to GitHub Issue.

@TomSweeneyRedHat
Copy link
Member

LGTM

@jwhonce jwhonce force-pushed the wip/connection branch 2 times, most recently from 66b96ef to 5a4ae97 Compare July 15, 2020 16:41
vrothberg
vrothberg reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hard time understanding how this change fixes a panic and which one. We really need tests to catch regressions.

@jwhonce
Copy link
Member Author

jwhonce commented Jul 16, 2020

@vrothberg This is a bandaid, #6938 is a refactor of this code and includes better test coverage.

@rhatdan
Copy link
Member

rhatdan commented Jul 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@edsantiago
Copy link
Member

I still see an identity flag in cmd/podman/root.go, should that be removed?

@openshift-merge-robot openshift-merge-robot merged commit f4766e0 into containers:master Jul 16, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@baude baude Awaiting requested review from baude

@mheon mheon Awaiting requested review from mheon

Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jwhonce @openshift-ci-robot @TomSweeneyRedHat @rhatdan @edsantiago @vrothberg @openshift-merge-robot