libpod.conf: Podman's conmon path on openSUSE #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the path to Podman's conmon for openSUSE and SLE. Signed-off-by: Valentin Rothberg <[email protected]>
|
LGTM |
|
LGTM. Travis is a known failure while we sort out test issues, I'll rekick Fedora. |
|
bot, retest this please |
|
@vrothberg I just got something in that should fix travis tests, but I think you will need to rebase your PR> |
|
LGTM other than the unhappy Travis tests that @rhatdan has a fix for. |
|
I'm going to merge this, given it's just a trivial config change. |
|
📌 Commit 1dc8f41 has been approved by |
|
☀️ Test successful - status-papr |
mheon
added a commit
to mheon/libpod
that referenced
this pull request
Aug 24, 2020
We need this release out by end of day, so we don't have time to do this right. Disable the vendor task and manually add c/storage PR containers#698 to the vendored copy of c/storage to make the tests pass. Once containers#698 merges into c/storage, we need to remove this commit and backport it to the v1.20 stable branch, then cut a release there. Signed-off-by: Matthew Heon <[email protected]>
mheon
added a commit
to mheon/libpod
that referenced
this pull request
Aug 25, 2020
This reverts commit ae2ee65. This was a horrible hack that we did for time reasons, to get 2.0.5 out on schedule; now that it has been merged into c/storage properly we no longer need or want it. Signed-off-by: Matthew Heon <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the path to Podman's conmon for openSUSE and SLE.
Signed-off-by: Valentin Rothberg [email protected]