-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of entrypoint #6939
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #6935 |
LGTM
…On Sat, Jul 11, 2020, 08:27 Daniel J Walsh ***@***.***> wrote:
Fixes: #6935 <#6935>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6939 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCGMGXGNXB7VYLNTORTR3BLEBANCNFSM4OXJC2EA>
.
|
That looks weird. How can a PR be approved by the same person who created it? |
Repo maintainers (anyone in the OWNERS file in repo root) are auto-approved. We mostly use approved to indicate that a PR is OK to proceed to review. Merge still requires an LGTM from two separate maintainers, who may not be the original submitter. |
cde5035
to
8bd68fe
Compare
@vincent-olivert-riera I agree, but for now, I just want to get one of them in. I will talk to @baude about it. |
628406b
to
cab062a
Compare
If a user specifies an entrypoint of "" then we should not use the images entrypoint. Signed-off-by: Daniel J Walsh <[email protected]>
LGTM |
/lgtm |
Thanks everyone! |
If a user specifies an entrypoint of "" then we should not use the images
entrypoint.
Signed-off-by: Daniel J Walsh [email protected]