Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of entrypoint #6939

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 11, 2020

If a user specifies an entrypoint of "" then we should not use the images
entrypoint.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Jul 11, 2020

Fixes: #6935

@mheon
Copy link
Member

mheon commented Jul 11, 2020 via email

@vincent-olivert-riera
Copy link

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhatdan

That looks weird. How can a PR be approved by the same person who created it?

@mheon
Copy link
Member

mheon commented Jul 11, 2020

Repo maintainers (anyone in the OWNERS file in repo root) are auto-approved. We mostly use approved to indicate that a PR is OK to proceed to review. Merge still requires an LGTM from two separate maintainers, who may not be the original submitter.

@rhatdan rhatdan force-pushed the entrypoint branch 3 times, most recently from cde5035 to 8bd68fe Compare July 13, 2020 18:03
@vincent-olivert-riera
Copy link

@rhatdan , your commit for fixing the absence of systemd in the Fedora image clashes with this other PR: #6952

The one that gets merged first will win and the other one will need to rebase, of course. But perhaps you want to coordinate with the creator of the other PR.

@rhatdan
Copy link
Member Author

rhatdan commented Jul 13, 2020

@vincent-olivert-riera I agree, but for now, I just want to get one of them in. I will talk to @baude about it.

@rhatdan rhatdan force-pushed the entrypoint branch 5 times, most recently from 628406b to cab062a Compare July 14, 2020 12:29
If a user specifies an entrypoint of "" then we should not use the images
entrypoint.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Jul 14, 2020

@QiWang19
Copy link
Contributor

LGTM

@mheon
Copy link
Member

mheon commented Jul 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 50cd21e into containers:master Jul 14, 2020
@vincent-olivert-riera
Copy link

Thanks everyone!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants